Repository navigation
Run the Version Release PR checks through GitHub's workflow approval - #877
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #876
Checklist
Description
The Version Release PR still needed an admin merge on #873. The
workflow_dispatchfrom #872 ran the checks on the PR's head commit, but GitHub doesn't link those runs to the PR, so the requiredbuild (N)checks never showed up on it.A PR opened with
GITHUB_TOKENalready gets itspull_requestruns, they just wait for someone with write access to select Approve workflows to run in the merge box (docs). That's GitHub's intended way for this. So I removed the dispatch step, theactions: writeit needed and theworkflow_dispatchtrigger onpull-request.yml. GitHub shows that button in the PR's merge box, so once the runs are approved the PR should merge like any other.Options I didn't go with:
build (N)statuses or check runs from the release workflow. That fakes the required checks instead of running them.POST /actions/runs/{id}/approve. It's only documented for fork PRs from first-time contributors, and it would defeat the point of the approval.actionlint passes. Whether the approved runs count can only be checked on the next release, since runs only wait for approval when the workflow opens or updates the PR. I'll update the "Releasing a version" wiki page after this merges.
🤖 Generated with Claude Code